Messages in this thread | | | Date | Fri, 14 May 2004 16:25:35 +0200 | Subject | Re: [PATCH] AES i586 optimized, regparm fixed | From | Fruhwirth Clemens <> |
| |
On Fri, May 14, 2004 at 09:48:08AM -0400, James Morris wrote: > On Fri, 14 May 2004, Fruhwirth Clemens wrote: > > > James, if the patch suits your taste, please take care of forwarding it to > > Andrew or Linus. > > There is still the binary license issue, and how to ensure this is built > instead of the generic AES module for the right architectures.
It's the standard BSD license. I would really be suprised if that's the first BSD code in the kernel. The issue should be handled like in the other case, although I'm not interested in wheter the license text stays or is purged.
A simple solution for implementation selection would be to add "depends on !X86 || X86_64" to aes generic. MODULE_ALIAS will take care of the rest.
I have to state that I'm not interested in developing a more complicated framework for automatic cipher selection. I've always been opposing configuration wizard and install scripts with magic-logic-that-will-configure-software-entirely-on-its-own-and-totally-wrong gimmicks. My aim is to provide a good/working aes-i586 patch.
Regards, Clemens [unhandled content-type:application/pgp-signature] | |