lkml.org 
[lkml]   [2004]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Remove hardcoded offsets from i386 asm
Vincent Hanquez wrote:
> On Thu, May 13, 2004 at 10:40:10PM -0400, Brian Gerst wrote:
>
>>Generate offsets for thread_info, cpuinfo_x86, and a few others instead
>>of hardcoding them.
>
>
> Hi Brian,
>
> why not keeping all macro name in uppercase ?
>
> the patch would look a lot smaller, and as the macro got the same
> meaning, I don't see why the name should change.
>
>
>>- movl TI_FLAGS(%ebp), %ecx
>>+ movl TI_flags(%ebp), %ecx
>
>
> Cheers,

To follow the convention of having the member name in lower case.

--
Brian Gerst
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.047 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site