Messages in this thread Patch in this message | | | Date | Fri, 14 May 2004 16:29:19 -0700 | From | Andrew Morton <> | Subject | Re: sysfs warning + spinlock BUG in typhoon radio |
| |
"Randy.Dunlap" <rddunlap@osdl.org> wrote: > > Calling initcall 0xc10bc558: typhoon_init+0x0/0x12a() > Typhoon Radio Card driver v0.1 > CLASS: registering class device: ID = 'radio2' > class_hotplug - name = radio2 > videodev: "Typhoon Radio" has no release callback. Please fix your driver for proper sysfs support, see http://lwn.net/Articles/36850/ > radio-typhoon: port 0x316. > radio-typhoon: mute frequency is 87500 kHz. > eip: c0b946cc > ------------[ cut here ]------------ > kernel BUG at include/asm/spinlock.h:120!
Does this fix?
diff -puN drivers/media/radio/radio-typhoon.c~typhoon-locking-fix drivers/media/radio/radio-typhoon.c --- 25/drivers/media/radio/radio-typhoon.c~typhoon-locking-fix Fri May 14 16:26:46 2004 +++ 25-akpm/drivers/media/radio/radio-typhoon.c Fri May 14 16:28:29 2004 @@ -326,7 +326,6 @@ static int __init typhoon_init(void) return -EINVAL; } typhoon_unit.iobase = io; - init_MUTEX(&typhoon_unit.lock); if (mutefreq < 87000 || mutefreq > 108500) { printk(KERN_ERR "radio-typhoon: You must set a frequency (in kHz) used when muting the card,\n"); @@ -337,6 +336,7 @@ static int __init typhoon_init(void) #endif /* MODULE */ printk(KERN_INFO BANNER); + init_MUTEX(&typhoon_unit.lock); io = typhoon_unit.iobase; if (!request_region(io, 8, "typhoon")) { printk(KERN_ERR "radio-typhoon: port 0x%x already in use\n", _
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |