lkml.org 
[lkml]   [2004]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Linux 2.6.6 "IDE cache-flush at shutdown fixes"
    Pavel Machek <pavel@ucw.cz> wrote:
    >
    > > > It's a bit grubby, but we could easily add a fourth state to
    > > > `system_state': split SYSTEM_SHUTDOWN into SYSTEM_REBOOT and SYSTEM_HALT.
    > > > That would be a quite simple change.
    > >
    > > Like this. I checked all the SYSTEM_FOO users and none of them seem to
    > > care about the shutdown state at present. Easy.
    >
    > Perhaps this should be parameter to device_shutdown? This is quite
    > ugly.

    Rather than a parameter to ->shutdown it would be better to add a new
    ->restart method to devices and IDE can implement one of those.

    I don't know if it's worth the effort though. Is any other driver likely
    to want to discriminate between reboot and shutdown?

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:03    [W:0.022 / U:152.196 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site