Messages in this thread |  | | | Date | Fri, 14 May 2004 13:33:53 -0700 | | From | Andrew Morton <> | | Subject | Re: [PATCH 2.6.6] bootmem.c cleanup |
| |
Michael Buesch <mbuesch@freenet.de> wrote: > > - if (!test_and_clear_bit(i, bdata->node_bootmem_map)) > - BUG(); > + BUG_ON(!test_and_clear_bit(i, bdata->node_bootmem_map));
Please don't put expressions whihc actually change state inside BUG_ON(). Someone may decide to make BUG_ON() a no-op to save space.
I'm not aware of anyone actually trying that, but it's a good objective. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |