lkml.org 
[lkml]   [2004]   [May]   [14]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateFri, 14 May 2004 08:28:55 +0200
SubjectRe: [PATCH] Remove hardcoded offsets from i386 asm
FromVincent Hanquez <>
On Thu, May 13, 2004 at 10:40:10PM -0400, Brian Gerst wrote:
> Generate offsets for thread_info, cpuinfo_x86, and a few others instead 
> of hardcoding them.

Hi Brian,

why not keeping all macro name in uppercase ?

the patch would look a lot smaller, and as the macro got the same
meaning, I don't see why the name should change.

> -	movl TI_FLAGS(%ebp), %ecx
> +	movl TI_flags(%ebp), %ecx

Cheers,
-- 
Tab
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 13:03    [from the cache]
©2003-2008