![]() | |||||||||||||
Messages in this thread |
On Thu, 2004-05-13 at 16:59, William Lee Irwin III wrote: > On Thu, May 13, 2004 at 09:05:50AM +0300, Muli Ben-Yehuda wrote: > > These two global variables do not appear to be used anywhere in this > > patch? > > > +static inline unsigned long __do_mmap_pgoff(struct file * file, unsigned long addr, > > __do_mmap_pgoff seems rather long to be inline? > > Atop my other patch to nuke the unused global variables, here is a patch > to manually inline __do_mmap_pgoff(), removing the inline usage. Untested. > Are you sure you want this? #ifdef'ing out the hugetlb case is somewhat > more digestible with the inline in place, e.g.: Well, I did the breakup in 2 pieces in the first place for 2 reasons: - the original patch had some subtle issues with accounting - do_mmap_pgoff is already such a mess, let's not make it worse I mean, it's awful to get anything right in this function, especially the cleanup/exit path, which is why I think it's more maintainable cut in 2. Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 13:03 [from the cache] ©2003-2008 | |||||||||||||