Messages in this thread |  | | | Date | Thu, 13 May 2004 18:02:34 +0200 | | From | Jörn Engel <> | | Subject | Re: [4KSTACK][2.6.6] Stack overflow in radeonfb |
| |
On Thu, 13 May 2004 11:36:36 -0400, Valdis.Kletnieks@vt.edu wrote: > On Thu, 13 May 2004 17:15:49 +0200, =?iso-8859-1?Q?J=F6rn?= Engel said: > > > Even quicker fix: > > > > --- linux-2.6/drivers/video/aty/radeon_base.c~ 2004-05-13 16:51:08.000 > 000000 +0200 > > +++ linux-2.6/drivers/video/aty/radeon_base.c 2004-05-13 16:55:09.000000000 + > 0200 > > @@ -1397,7 +1397,7 @@ > > { > > struct radeonfb_info *rinfo = info->par; > > struct fb_var_screeninfo *mode = &info->var; > > - struct radeon_regs newmode; > > + static struct radeon_regs newmode; > > int hTotal, vTotal, hSyncStart, hSyncEnd, > > hSyncPol, vSyncStart, vSyncEnd, vSyncPol, cSync; > > u8 hsync_adj_tab[] = {0, 0x12, 9, 9, 6, 5}; > > Is that racy if you have more than one graphics card installed?
Could be. It's a quick hack, just like the kmalloc() variant. For the solution, see my previous mail.
Jörn
-- I can say that I spend most of my time fixing bugs even if I have lots of new features to implement in mind, but I give bugs more priority. -- Andrea Arcangeli, 2000 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |