![]() | |||||||||||||
Messages in this thread |
On Fri, Apr 30, 2004 at 11:04:24AM +0200, Duncan Sands wrote: > On Tuesday 27 April 2004 10:58, Oliver Neukum wrote: > > Am Dienstag, 27. April 2004 00:14 schrieb Greg KH: > > > On Mon, Apr 26, 2004 at 04:05:17PM +0200, Duncan Sands wrote: > > > > diff -Nru a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c > > > > --- a/drivers/usb/core/devio.c Mon Apr 26 13:48:28 2004 > > > > +++ b/drivers/usb/core/devio.c Mon Apr 26 13:48:28 2004 > > > > @@ -350,8 +350,8 @@ > > > > * all pending I/O requests; 2.6 does that. > > > > */ > > > > > > > > - if (ifnum < 8*sizeof(ps->ifclaimed)) > > > > - clear_bit(ifnum, &ps->ifclaimed); > > > > + BUG_ON(ifnum >= 8*sizeof(ps->ifclaimed)); > > > > > > I've changed that to a WARN_ON(). Yeah, writing over memory is bad, but > > > oopsing is worse. Let's be a bit nicer than that. > > > > You aren't nice that way. An oops has localised consequences. Scribbling > > over memory can cause anything. > > Hi Greg, if won't accept a BUG_ON, how about the following? Fine with me, applied, thanks. greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 13:02 [from the cache] ©2003-2008 | |||||||||||||