Messages in this thread | | | Subject | Re: dd PATCH: add conv=direct | From | (Paul Jarc) | Date | Thu, 08 Apr 2004 15:51:11 -0400 |
| |
Paul Eggert <eggert@CS.UCLA.EDU> wrote: > Jim Meyering <jim@meyering.net> writes: >> 2004-04-08 Jim Meyering <jim@meyering.net> >> >> * src/dd.c (set_fd_flags): Don't OR in -1 when fcntl fails. > > Doesn't that fix generate worse code in the usual case, since it > causes two conditional branches instead of one?
I think it's unnecessary anyway - if old_flags is -1, then the conditional jumps to error() before looking at new_flags at all.
paul - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |