[lkml]   [2004]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix
    On Tue, Apr 06, 2004 at 11:54:41PM +0200, Andrea Arcangeli wrote:
    > Christoph, I got no positive feedback yet for the alternate fix you
    > proposed and it's not obvious to my eyes (isn't good_pages going to be
    > screwed with your fix?), but I wanted to checkin a fix into CVS in the
    > meanwhile, so for now I've checked in my __GFP_NO_COMP fix that I'm sure
    > doesn't require any testing since it's obviously safe and it should
    > definitely fix the problem. This way you can also take your time for the
    > testing of your better fix.
    > What's not clear to me about your fix is if it's really working safe
    > with good_pages being overdecremented (good_pages doesn't look just an
    > hint, there seems to be a valid reason you're doing the set_bit/test_bit
    > on page->private, no?).

    Ignore the first part of that patch, it was misdirected (Christoph
    woulda gone through and put guards around all pagebuf page->private
    users; turns out the first change was unnecessary, and confusing ;).


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 14:02    [W:0.020 / U:11.000 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site