Messages in this thread | | | Subject | Re: [patch 1/3] efivars driver update and move | From | Alex Williamson <> | Date | Thu, 29 Apr 2004 16:08:15 -0600 |
| |
On Thu, 2004-04-29 at 15:19, Matt Domsch wrote: > On Thu, Apr 29, 2004 at 01:50:54PM -0600, Alex Williamson wrote: > > # stat BootOrder-8be4df61-93ca-11d2-aa0d-00e098032b8c\ / > > File: `BootOrder-8be4df61-93ca-11d2-aa0d-00e098032b8c /' > > FWIW, my Intel Tiger2-based system doesn't have the space at the end... > > > *(short_name + strlen(short_name)) = '-'; > > efi_guid_unparse(vendor_guid, short_name + strlen(short_name)); > > *(short_name + strlen(short_name)) = ' '; > > even though looking at this I would have expected it to...
Yeah, I'm not sure how you couldn't have a space at the end...
> > Can you remove that last line and see what it does? Best as I can > tell, it isn't necessary or desired.
Yes, removing that last line above gets rid of the space, everything looks right, and efibootmgr doesn't complain. I'd attach a patch but I'm curious if Matt T. had some reason for adding it.
Alex
-- Alex Williamson HP Linux & Open Source Lab
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |