lkml.org 
[lkml]   [2004]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: 2.6.6-rc{1,2} bad VM/NFS interaction in case of dirty page writeback
    From
    Date
    On Tue, 2004-04-27 at 21:02, Andrew Morton wrote:
    > Shantanu Goel <sgoel01@yahoo.com> wrote:
    > >
    > > Andrew/Trond,
    > >
    > > Any consensus as to what the right approach is here?
    >
    > For now I suggest you do
    >
    > - err = WRITEPAGE_ACTIVATE;
    > + err = 0;
    >
    > in nfs_writepage().

    That will just cause the page to be put back onto the inactive list
    without starting writeback. Won't that cause precisely those kswapd
    loops that Shantanu was worried about?
    AFAICS if you want to do this, you probably need to flush the page
    immediately to disk on the server using a STABLE write as per the
    appeanded patch. The problem is that screws the server over pretty hard
    as it will get flooded with what are in effect a load of 4k O_SYNC
    writes.

    Cheers,
    Trond


    --- linux-2.6.6-rc2/fs/nfs/write.c.orig 2004-04-27 16:01:01.000000000 -0400
    +++ linux-2.6.6-rc2/fs/nfs/write.c 2004-04-27 21:18:58.000000000 -0400
    @@ -313,7 +313,7 @@
    if (err >= 0) {
    err = 0;
    if (wbc->for_reclaim)
    - err = WRITEPAGE_ACTIVATE;
    + nfs_flush_inode(inode, 0, 0, FLUSH_STABLE);
    }
    } else {
    err = nfs_writepage_sync(NULL, inode, page, 0,
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:02    [W:3.215 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site