Messages in this thread | | | Date | Sun, 25 Apr 2004 08:25:38 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 8/15] New set of input patches: atkbd - use bitfields |
| |
Hi!
> > > > ChangeSet@1.1909, 2004-04-20 22:29:12-05:00, dtor_core@ameritech.net > > Input: remove unneeded fields in atkbd structure, convert to bitfields > > I think this is incorrect. We cannot set the bits in bitfields > atomically, which we need in some cases. We probably need to add > volatiles to some of them, too.
If you need volatile in the driver, then the driver is probably buggy. Pavel -- 64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |