Messages in this thread | | | Date | Sun, 25 Apr 2004 01:55:15 +0100 (BST) | From | James Simmons <> | Subject | Re: [Linux-fbdev-devel] [PATCH] neofb patches |
| |
> Umm, I would really appreciate it if you didn't silently leave out bits of > my patches and then just say "I merged your patches". It took me a little > bit to figure out that the reason panning now isn't used for fbconsole > scrolls is because you just didn't bother to put that part of my patch in. > > Is there some reason you left out the following piece of my modedb patch? > > + /* Turn on panning for console scroll by default */ > + info->var.yres_virtual = 30000; > + info->var.accel_flags |= FB_ACCELF_TEXT; > + if (neofb_check_var(&info->var, info)) > + goto err_map_video;
The reason is because fb_find_mode calls check_var for us. No reason to call it twice. The large yres_virtual being 30000 that is not needed any longer. The accel flag is set in neofb_check_var. The current test is
if (var->bits_per_pixel >= 24 || !par->neo2200) var->accel_flags &= ~FB_ACCEL_TEXT;
Should we drop the bpp >= 24 test? Do you observe this problem at all depths.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |