Messages in this thread | | | Date | Wed, 21 Apr 2004 13:34:02 +0200 | From | Jan-Benedict Glaw <> | Subject | Re: [PATCH 5/15] New set of input patches: lkkbd simplify checks |
| |
On Wed, 2004-04-21 00:53:07 -0500, Dmitry Torokhov <dtor_core@ameritech.net> wrote in message <200404210053.09166.dtor_core@ameritech.net>: > --- a/drivers/input/keyboard/lkkbd.c Tue Apr 20 23:01:41 2004 > +++ b/drivers/input/keyboard/lkkbd.c Tue Apr 20 23:01:41 2004 > @@ -527,9 +527,7 @@ > > if ((serio->type & SERIO_TYPE) != SERIO_RS232) > return; > - if (!(serio->type & SERIO_PROTO)) > - return; > - if ((serio->type & SERIO_PROTO) && (serio->type & SERIO_PROTO) != SERIO_LKKBD) > + if ((serio->type & SERIO_PROTO) != SERIO_LKKBD) > return; > > if (!(lk = kmalloc (sizeof (struct lkkbd), GFP_KERNEL)))
Looks good. I'll take this patch inty my "master" version.
MfG, JBG
-- Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 "Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); [unhandled content-type:application/pgp-signature] | |