Messages in this thread | | | Date | Wed, 21 Apr 2004 16:27:25 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] s390 (7/9): oprofile for s390. |
| |
On Wed, Apr 21, 2004 at 04:48:29PM +0200, Martin Schwidefsky wrote: > +++ linux-2.6-s390/arch/s390/kernel/irq.c Wed Apr 21 16:29:40 2004 > @@ -0,0 +1,72 @@ > +/* > + * arch/s390/kernel/irq.c > + * > + * Contains functions related to oprofile taken from patch > + * linux-2.4.20-s390-oprofile.patch. > + * > + * Copyrith (C) 2003 IBM Deutschland Entwicklung GmbH, IBM Corporation > + * Author(s): Thomas Spatzier (tspat@de.ibm.com) > + * > + */
Don't you think the name for this file is completly wrong? And a patch name in the comment about this file doesn't exactly help either..
> +#include <linux/smp_lock.h>
What do you need this one for?
> +#include <linux/init.h>
doesn't seem to be need either.
> +#include <asm/system.h>
dito?
> +#include <asm/io.h>
dito. I wonder why this actually exists on s390..
> +#include <asm/pgtable.h> > +#include <asm/delay.h>
dito.
> +static inline void s390_do_profile(struct pt_regs * regs) > +{ > + unsigned long eip; > + extern unsigned long prof_cpu_mask; > + > + profile_hook(regs); > + > + if (user_mode(regs)) > + return; > + > + if (!prof_buffer) > + return; > + > + eip = instruction_pointer(regs); > + > + /* > + * Only measure the CPUs specified by /proc/irq/prof_cpu_mask. > + * (default is all CPUs.) > + */ > + if (!((1<<smp_processor_id()) & prof_cpu_mask))
shouldn't this be cpumask_t arithmetic?
> +//extern int irq_init(struct oprofile_operations** ops);
why this?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |