Messages in this thread | | | From | "Robert W. Maloy" <> | Subject | Re: Possible error in fs/buffer.c | Date | Fri, 2 Apr 2004 05:46:57 -0500 |
| |
> Andrew Morton wrote: > This is saying "is the buffer is not on any list, then place it on > the mapping's list now. If the buffer _is_ already on some list > then we know it must already be on mapping->private_list, so we > have nothing to do". > > Re-dirtying an already-dirty buffer is an extremely common case, > and here we look for an opportunity to avoid dirtying a cacheline > or two.
This makes some since except that buffer_insert_list(&buffer_mapping->private_lock, bh, &mapping->private_list);
only adds &bh->b_assoc_buffers to the end of mapping->private_list not the buffer itself.
-- Cheers Rob Maloy r.w.maloy@acm.org (410) 854-6637 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |