Messages in this thread | | | Date | Fri, 2 Apr 2004 20:05:37 -0700 | From | Tom Rini <> | Subject | Re: [PATCH][2.6-mm] early_param console_setup clobbers commandline |
| |
On Fri, Apr 02, 2004 at 08:32:10PM -0500, Zwane Mwaikambo wrote: > console_setup clobbers the argument it's passed, resulting in > the commandline being chopped (it inserts a '\0'). A sample command line > would be; > > ro root=/dev/hda1 profile=2 debug console=tty0 console=ttyS0,38400 hugepages=20 nmi_watchdog=2 > > would end up like; > > ro root=/dev/hda1 profile=2 debug console=tty0 console=ttyS0
This shouldn't be a problem 'tho, since we don't allow for spaces in args, and we do find where the next space is, and ensure it's still a space after the call (because console can splice up the command line, but we'd skip over those bits anyhow).
> I believe this may be the only setup call which clobbers the argument, so > how about we pass a copy (i wasn't sure about what would be a decent > argument length so i just went with COMMAND_LINE_SIZE (ugly, yes)? > Something like the following tested patch;
pci= will clobber as well, which is why I thought I asked Andrew to drop that part of the i386 patch (but perhaps I forgot, and with Rusty's patch, it becomes a non-issue again).
-- Tom Rini http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |