![]() | |||||||||||||
Messages in this thread |
[CC: list pruned on the assumption that most recipients aren't interested] On Fri, 2 Apr 2004, Maneesh Soni wrote: > Yes, see the patch below. Probably the race window has become smaller but > Badness message is also an indication that somewhere kobject_cleanup has > started. I have not yet seen why race is still there. Yes. Although the problem can't be due to a race if it involves code that's protected by a semaphore. Did this Badness message come from within check_perm()? I don't see how that could happen with this patch. You're guaranteed that the refcount is positive until after sysfs_remove_dir() returns. It's _supposed_ to be positive, anyway; maybe it isn't. You could try checking for that, at the end of sysf_remove_dir(). > There is one more bigger problem in this approach. It may miss kobject_put() in > sysfs_release() call and result will be memory leak, ->release() is not called, > rmmod hang, etc etc. So using ->d_fsdata for this purpose is not the proper > solution, IMO. You're quite correct. d_fsdata must remain set so that previous references can be dropped. Some other part of the dentry or the inode has to be used instead. I don't know what would be appropriate, perhaps one of the flags bits. Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 13:02 [from the cache] ©2003-2008 | |||||||||||||