lkml.org 
[lkml]   [2004]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.6-rc1-mm1
Ian Kent <raven@themaw.net> wrote:
>
> On Mon, 19 Apr 2004, Christoph Hellwig wrote:
>
> > 4-autofs4-2.6.0-expire-20040405.patch exports vfsmount_lock which is probably
> > not exactly a good design. It's only used by autofs4_may_umount which isn't
> > autofs-specific at all.
> >
>
> Sorry Christoph, your recommendation is?
>

May as well rename that function to may_umount(), document it, suck it into
fs/namespace.c or fs/namei.c and export it to modules.

That does increase the size of the static kernel a little, so arguably we
shouldn't make this change until/unless we see a second user of the
function.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [W:0.916 / U:1.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site