Messages in this thread Patch in this message | | | Date | Mon, 19 Apr 2004 18:39:23 +0200 (MEST) | From | Geert Uytterhoeven <> | Subject | Re: [PATCH] Clean up asm/pgalloc.h include (m68k) |
| |
On Mon, 19 Apr 2004, Russell King wrote: > On Mon, Apr 19, 2004 at 06:18:41PM +0200, Geert Uytterhoeven wrote: > > Do you really need <asm/pgalloc.h> in include/asm-generic/tlb.h? > > Yes it does - tlb.h uses check_pgt_cache(). Also, architecture code > makes use of __pmd_free_tlb and __pte_free_tlb, both of which make > use of code from asm/pgalloc.h. > > Not including asm/pgalloc.h into asm/tlb.h or asm-generic/tlb.h means > that all the generic files have to know that asm/tlb.h needs asm/pgalloc.h, > and they also then need to know that asm/pgalloc.h needs asm/pgtable.h, > and asm/pgtable.h needs ... > > Is there a reason why: > > static inline void __pte_free_tlb(struct mmu_gather *tlb, struct page *page) > { > tlb_remove_page(tlb, page); > } > > can't be like x86 and others in their pgalloc.h:
(because we more like static inline functions than macros?)
> #define __pte_free_tlb(tlb,pte) tlb_remove_page((tlb),(pte)) > > (for consistency sake if nothing else) ?
Ah, I didn't look at ia32. That solution is fine for me! Here's the additional patch:
--- linux-m68k-2.6.6-rc1-rmk/include/asm-m68k/sun3_pgalloc.h 2004-04-04 11:08:37.000000000 +0200 +++ linux-m68k-2.6.6-rc1-geert/include/asm-m68k/sun3_pgalloc.h 2004-04-19 18:37:37.000000000 +0200 @@ -31,10 +31,7 @@ __free_page(page); }
-static inline void __pte_free_tlb(struct mmu_gather *tlb, struct page *page) -{ - tlb_remove_page(tlb, page); -} +#define __pte_free_tlb(tlb,pte) tlb_remove_page((tlb),(pte))
static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm, unsigned long address) Gr{oetje,eeting}s, Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |