Messages in this thread | | | Date | Fri, 16 Apr 2004 23:08:56 -0400 | From | Bill Nottingham <> | Subject | Re: [linux-usb-devel] oops when loading ehci_hcd |
| |
David Brownell (david-b@pacbell.net) said: > Looks like a cleanup path needs to handle early failure a bit better; > likely just having ehci_stop test for ehci->async non-null (before > calling scan-async to clean up any pending work) would suffice.
This patch solves the oops for me - thanks!
Bill
> --- 1.75/drivers/usb/host/ehci-hcd.c Wed Apr 14 20:20:58 2004 > +++ edited/drivers/usb/host/ehci-hcd.c Fri Apr 16 11:03:50 2004 > @@ -592,7 +592,8 @@ > > /* root hub is shut down separately (first, when possible) */ > spin_lock_irq (&ehci->lock); > - ehci_work (ehci, NULL); > + if (ehci->async) > + ehci_work (ehci, NULL); > spin_unlock_irq (&ehci->lock); > ehci_mem_cleanup (ehci); >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |