lkml.org 
[lkml]   [2004]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Increase number of dynamic inodes in procfs (2.6.5)
    Nathan Lynch <nathanl@austin.ibm.com> wrote:
    >
    > Andrew Morton wrote:
    > > Nathan Lynch <nathanl@austin.ibm.com> wrote:
    > >
    > >>>This open-codes a simple version of lib/idr.c. Please use lib/idr.c
    > >>
    > >> > instead. There's an example in fs/super.c
    > >>
    > >> Ok, thanks for the tip. Is this better?
    > >
    > >
    > > Looks OK. How well tested was it? Nothing calls init_proc_inum_idr().
    > > Maybe all-zeroes happens to work.
    >
    > Sorry, I tested it all day; it just happens to work :)

    heh. It gave me an instasplat with spinlock debugging enabled.

    > I think
    > the call to idr_remove in fs/super.c::set_anon_super needs to be holding
    > unnamed_dev_lock.

    Indeed. I'll fix that up, thanks.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:02    [W:0.019 / U:1.744 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site