lkml.org 
[lkml]   [2004]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] anobjrmap 9 priority mjb tree
"Martin J. Bligh" <mbligh@aracnet.com> wrote:
>
> Turns out he'd turned the
> locking in find_get_page from "spin_lock(&mapping->page_lock)" into
> "spin_lock_irq(&mapping->tree_lock)",

That's from the use-radix-tree-walks-for-writeback code.

Use oprofile - it's NMI-based.

> and I'm using readprofile, which
> doesn't profile with irqs off, so it's not really disappeared, just hidden.
> Not sure which sub-patch that comes from, and it turned out to be a bit of
> a dead end, but whilst I'm there, I thought I'd point out this was contended,
> and show the diffprofile with and without spinline for aa5:
>
> 22210 246777.8% find_trylock_page
> 2538 36.4% atomic_dec_and_lock

profiler brokenness, surely. Almost nothing calls find_trylock_page(),
unless Andrea has done something peculiar. Use oprofile.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [from the cache]
©2003-2011 Jasper Spaans