lkml.org 
[lkml]   [2004]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][RFC] sort out CLOCK_TICK_RATE usage [0/3]
On Mon, Apr 12, 2004 at 12:47:08PM -0400, Zwane Mwaikambo wrote:
> On Mon, 12 Apr 2004, Thorsten Kranzkowski wrote:
>
> > With every 2.6 kernel I tried the system speaker on my Alpha produces a
> > rather unpleasant high pitched tone instead of the normal system beep.
> > This is because in p|cspkr.c the calculation of the counter values is
> > incorrectly based on CLOCK_TICK_RATE.
> > To solve this problem I came up with these tree patches:
> >
> > 1/3: introduce PIC_TICK_RATE constant. It seems this is not always
> > the same value.
> > 2/3: use PIC_TICK_RATE in *spkr.c and some other places where the
> > PIC is directly programmed.
> > 3/3: use CLOCK_TICK_RATE where 1193180 was used in timing calculations.
> >
> > Tested on Alpha, compile & boot-tested on i386 (unrelated LVM problems here)
> >
> > Arch maintainers please have a look whether I got the constants right or
> > if your architecture has a PIC at all.
>
> Isn't this supposed to be PIT_TICK_RATE?


I reused the define in arch/alpha/kernel/time.c that served exactly
the same purpose. I have no problems to call this a timer instead
of a counter, though. :)


Bye,
Thorsten


--
| Thorsten Kranzkowski Internet: dl8bcu@dl8bcu.de |
| Mobile: ++49 170 1876134 Snail: Kiebitzstr. 14, 49324 Melle, Germany |
| Ampr: dl8bcu@db0lj.#rpl.deu.eu, dl8bcu@marvin.dl8bcu.ampr.org [44.130.8.19] |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [W:0.101 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site