lkml.org 
[lkml]   [2004]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: hangcheck watchdog triggers if clock=pit. Missing code in monotonic_clock_pit()?
    From
    Date
    On Sat, 2004-04-10 at 06:35, Denis Vlasenko wrote:
    > linux-2.6.5/arch/i386/kernel/time.c:
    > ====================================
    > /* monotonic_clock(): returns # of nanoseconds passed since time_init()
    > * Note: This function is required to return accurate
    > * time even in the absence of multiple timer ticks.
    > */
    [snip]
    > linux-2.6.5/arch/i386/kernel/timers/timer_pit.c:
    > ================================================
    > static unsigned long long monotonic_clock_pit(void)
    > {
    > return 0;
    > }

    Part of the problem is that the PIT timesource cannot account for lost
    ticks, thus we cannot strictly conform to the
    monotonic_clock()interface.

    So either we just return (jiffies_64 * TICK_NSEC), and just have an
    exception to the rule, or the hangcheck watchdog needs to know what to
    do when monotonic_clock always returns zero.

    Joel: Do you have a preference?

    thanks
    -john


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:02    [W:0.022 / U:91.820 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site