lkml.org 
[lkml]   [2004]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: ip a flush problem on 2.6 kernels (fine on 2.4 kernels)
On Thu, 4 Mar 2004 03:08:15 +0100
Arkadiusz Miskiewicz <arekm@pld-linux.org> wrote:

> The problem is that
>
> ip a a 192.168.0.1/24 dev eth0
> ip link set eth0 down
> ip a flush dev eth0
>
> Here on my vanilla 2.6.2 it locks eating CPU - it does netlink
> communication over and over. This ,,hang'' doesn't happen when
> interface is in UP state. Also doesn't happen on 2.4 kernels.

I fixed it with this patch for iproute2 here. It's not clear to me at
all how it ever worked before. The loop seems to be just wrong.

-Andi

diff -u iproute2/ip/ipaddress.c~ iproute2/ip/ipaddress.c
--- iproute2/ip/ipaddress.c~ 2004-03-07 20:54:52.000000000 +0100
+++ iproute2/ip/ipaddress.c 2004-03-07 21:02:12.000000000 +0100
@@ -623,6 +623,9 @@
fflush(stdout);
return 0;
}
+#if 1
+ break;
+#else
round++;
if (flush_update() < 0)
exit(1);
@@ -630,6 +633,7 @@
printf("\n*** Round %d, deleting %d addresses ***\n", round, filter.flushed);
fflush(stdout);
}
+#endif
}
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 14:01    [W:0.026 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site