Messages in this thread | | | Subject | Re: [patch 1/22] Add __early_param for all arches | From | Rusty Russell <> | Date | Thu, 01 Apr 2004 12:56:45 +1000 |
| |
On Thu, 2004-04-01 at 12:24, Tom Rini wrote: > > > > +/* Arch code calls this early on. */ > > > > +void __init parse_early_options(const char *saved_command_line) > > > > +{ > > > > + static char __initdata command_line[COMMAND_LINE_SIZE]; > > > > + strcpy(command_line, saved_command_line);
> memcpy(src, src, size) isn't good, is it? On i386 we start out with the > commandline in saved_command_line. Everyone else I believe has a local > var we point cmdline_p at, which gets copied into saved_command_line.
Read again. Not accessing global vars at all: it's a (probably badly named) parameter.
Rusty. -- Anyone who quotes me in their signature is an idiot -- Rusty Russell
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |