lkml.org 
[lkml]   [2004]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: route cache DoS testing and softirqs
On Tue, Mar 30, 2004 at 11:05:15AM +0530, Srivatsa Vaddagiri wrote:
> On Tue, Mar 30, 2004 at 10:36:14AM +0530, Srivatsa Vaddagiri wrote:
> > kthread_stop does:
> >
> > 1. kthread_stop_info.k = k;
> > 2. wake_up_process(k);
> >
> > and if ksoftirqd were to do :
> >
> > a. while (!kthread_should_stop()) {
> > b. __set_current_state(TASK_INTERRUPTIBLE);
> > c. schedule();
> > }
> >
> >
> > There is a (narrow) possibility here that a) happens _after_ 1) as well as
> > b) _after_ 2).
>
> hmm .. I meant a) happening _before_ 1) and b) happening _after_ 2) ..
>
> >
> > a. __set_current_state(TASK_INTERRUPTIBLE);
> > b. while (!kthread_should_stop()) {
> > c. schedule();
> > d. __set_current_state(TASK_INTERRUPTIBLE);
> > }
> >
> > e. __set_current_state(TASK_RUNNING);
> >
> > In this case, even if b) happens _after_ 1) and c) _after_ 2),
>
> Again I meant "even if b) happens _before_ 1) and c) _after_ 2) !!
>
> > schedule simply returns immediately because task's state would have been set
> > to TASK_RUNNING by 2). It goes back to the kthread_should_stop() check and
> > exits!

you're right, I had a private email exchange with Andrew about this
yesterday, he promptly pointed it out too. But my point is that the
previous code was broken too, it wasn't me breaking the code, I only
simplified already broken code instead of fixing it for real. His tree
should get the proper fixes soon. All those __ in front of the
set_current_state in that function made the ordering worthless and
that's why I cleaned them up.

The softirq part in the patch however is orthogonal to the above races,
so I didn't post an update since it didn't impact testing.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [W:0.252 / U:0.120 seconds]
©2003-2011 Jasper Spaans. Advertise on this site