Messages in this thread |  | | | Date | Mon, 29 Mar 2004 23:24:58 +0100 (BST) | | From | Hugh Dickins <> | | Subject | Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix |
| |
On Mon, 29 Mar 2004, Andrew Morton wrote: > > hmm, yes, we have pages which satisfy PageSwapCache(), but which are not > actually in swapcache. > > How about we use the normal pagecache APIs for this? > > + add_to_page_cache(page, &swapper_space, entry.val, GFP_NOIO); >... > + remove_from_page_cache(page);
Much nicer, and it'll probably appear to work: but (also untested) I bet you'll need an additional page_cache_release(page) - damn, looks like hugetlbfs has found a use for that tiresome asymmetry.
Hugh
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |