Messages in this thread | | | From | David Mosberger <> | Date | Thu, 25 Mar 2004 18:10:39 -0800 | Subject | Re: Fw: potential /dev/urandom scalability improvement |
| |
>>>>> On Thu, 25 Mar 2004 18:00:14 -0800, Andrew Morton <akpm@osdl.org> said:
Andrew> We may as well stick prefetch_range() in prefetch.h.
Fair enough.
Andrew> And Matt's patch series is not a thing I want to take on Andrew> board at present, so let's stick with the straight Andrew> scalability patch for now.
Andrew> I moved the prefetch_range() call to outside the spinlock. Andrew> Does that make sense?
The other CPUs will dirty that data, so prefetching it before you hold the lock is almost certainly bad for performance. (Well, to be precise, it really depends on the number of lines dirtied.)
--david - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |