Messages in this thread | | | Date | Tue, 23 Mar 2004 13:36:50 -0800 | From | Paul Jackson <> | Subject | Re: [PATCH] nodemask_t x86_64 changes [5/7] |
| |
Yes - making the *_complement ops into two operand (dst, src) would be a good idea, Bill. Thanks. I will likely include that in what I'm doing now.
Meanwhile, Matthew's patch 5/7 appears broken here.
My current understanding of the complement op is that it is broken for non-word multiple sizes. There's a good chance I'm still be confused on this matter.
It might make sense to redo this particular bit of offline logic not by using *_complement, but rather by looping over all nodes, and only acting if not online, thus avoiding the *_complement() operator for now. I have not thought through the performance implications of such a code inversion, however.
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.650.933.1373 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |