Messages in this thread |  | | | Date | Mon, 22 Mar 2004 06:07:02 +0100 | | From | Andrea Arcangeli <> | | Subject | Re: [PATCH] Drop O_LARGEFILE from F_GETFL for POSIX compliance |
| |
On Mon, Mar 22, 2004 at 05:45:12AM +0100, Andi Kleen wrote: > On Mon, 22 Mar 2004 05:34:54 +0100 > Andrea Arcangeli <andrea@suse.de> wrote: > > > > 32bit archs needs to get O_LARGEFILE in return from getfl (if they set > > it [it's not set implicitly in 32bit archs] they will be able to handle > > it transparently in glibc too, and I believe they really want it). 64bit > > archs not, hence the fix. > > If 32bit archs need it then 64bit archs need it too (think 32bit emulated processes > on 64bit jernels) But I think in practice it doesn't matter, so I would prefer to be > consistent between 32bit and 64bit. > > I don't feel very strongly about this however ...
I agree it'd be a lot simpler to handle 32bit user on 64bit kernel if we can clear it unconditionally (otherwise we've to trap getfl with a ia32 wrapper) but I'm afraid the api may break if we clear that bit unconditionally. I can't tell you for sure by memory though because the last time I worked on this was one year and half ago and this is really a matter of API. We should ask the glibc people for another confirmation before choosing if to clear it only in 64bit archs or in 32bit too. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |