lkml.org 
[lkml]   [2004]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ISDN Eicon driver: restructured capi list and lock handling
On Mon, 22 Mar 2004, Arjan van de Ven wrote:
>
> On Mon, Mar 22, 2004 at 05:32:42PM +0100, Arjan van de Ven wrote:
> > On Sun, 2004-03-21 at 17:55, Linux Kernel Mailing List wrote:
> > > ChangeSet 1.1828, 2004/03/21 08:55:24-08:00, armin@melware.de
> > >
> > > [PATCH] ISDN Eicon driver: restructured capi list and lock handling
> > >
> > > Restructered the CAPI code of list handling and lock.
> > >
> > > Removed obsolete code.
> >
> > this patch is broken:
> > Error: ./drivers/isdn/hardware/eicon/capifunc.o .altinstructions refers
> > to 00000018 R_386_32 .exit.text
> > Error: ./drivers/isdn/hardware/eicon/capifunc.o .init.text refers to
> > 0000015d R_386_PC32 .exit.text
> >
> > eg you call __exit functions from __init functions, which is
> > incorrect....
>
> and the fix:
>
> --- linux-2.6.4/drivers/isdn/hardware/eicon/capifunc.c~ 2004-03-22 17:12:30.868043408 +0100
> +++ linux-2.6.4/drivers/isdn/hardware/eicon/capifunc.c 2004-03-22 17:12:30.868043408 +0100
> @@ -455,7 +455,7 @@
> /*
> * remove cards
> */
> -static void DIVA_EXIT_FUNCTION divacapi_remove_cards(void)
> +static void divacapi_remove_cards(void)
> {
> DESCRIPTOR d;
> struct list_head *tmp;
>

Yes, you are correct. I wonder why my compiler didn't complain about this.
It works here and I don't know why. What configuration did you use?

I will create a correct incremental patch (another patch for this file is
already send to Linus) for Linus/Andrew.

Thanks for pointing out.

Armin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [W:0.048 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site