Messages in this thread | | | Date | Tue, 2 Mar 2004 08:04:18 -0700 | From | Tom Rini <> | Subject | Re: [Kgdb-bugreport] [KGDB PATCH][2/7] Serial updates, take 2 |
| |
On Tue, Mar 02, 2004 at 05:06:03PM +0530, Amit S. Kale wrote:
> This patch broke Ctrl+C response on my system. Fix as follows > With this fix I can kill or detach gdb with pending console messages and then > connect a new gdb. > > Is following fix ok to checkin? (interdiff) > > @@ -412,11 +418,11 @@ > + /* The user has selected one of ttyS[0-3], which we pull > + * from rs_table[]. If this doesn't exist, user error. */ > + gdb_async_info.port = gdb_async_info.state->port = > -+ rs_table[KGDB_PORT].port; > ++ rs_table[kgdb8250_ttyS].port; > + gdb_async_info.line = gdb_async_info.state->irq = > -+ rs_table[KGDB_PORT].irq; > -+ gdb_async_info.state->io_type = rs_table[KGDB_PORT].io_type; > -+ reg_shift = rs_table[KGDB_PORT].iomem_reg_shift; > ++ rs_table[kgdb8250_ttyS].irq; > ++ gdb_async_info.state->io_type = > rs_table[kgdb8250_ttyS].io_type; > ++ reg_shift = rs_table[kgdb8250_ttyS].iomem_reg_shift; > + } > + > + switch (gdb_async_info.state->io_type) {
Hmm. I take it you passed in a different ttyS than you configured for? Been a while since I tried that, and the above look correct. Go ahead.
-- Tom Rini http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |