![]() | |||||||||||||
Messages in this thread |
Dave Hansen <haveblue@us.ibm.com> writes: > On Sun, 2004-02-29 at 23:32, Eric W. Biederman wrote: > > I have rewritten and compiled tested the boot_ioremap code but I don't > > have a configuration to test it. This effects the EFI code and the > > numa srat code. It might be worth replacing boot_ioremap with __va() > > to reduce the amount of error checking necessary. > > I can probably have someone test it, but you're right, we don't really > need boot_ioremap() if we're going to map in all 4G at boot time. I'd > just prefer that you remove it completely in your patch. > > I can test it on some SRAT hardware if you'd like. I'd like. What I worry about with transforming boot_ioremap to __va are two things. 1) It is clear I haven't broken code that uses boot_ioremap if I don't touch them. At least not that way. 2) There is a weird case at 4G where an exception is generated if you cross that boundary. I forget if it is logical or physical address. Keeping the boot_ioremap interface I can at least try and avoid that. If I can get a clear picture of what I am avoiding and be certain that it won't happen I will remove all objections. But better safe than sorry at least for a start. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 13:01 [from the cache] ©2003-2008 | |||||||||||||