lkml.org 
[lkml]   [2004]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subjectkgdb: fix kgdbeth compilation and make it init late enough
Hi!

CONFIG_NO_KGDB_CPUS can not be found anywhere in the patches => its
probably not needd any more. init_kgdboe can't be module_initcall; in
such cases it initializes after tg3 network card (and that's bad).

Okay to commit?
Pavel

--- clean-mm/drivers/net/kgdb_eth.c 2004-03-01 22:03:55.000000000 +0100
+++ linux-mm/drivers/net/kgdb_eth.c 2004-03-01 23:00:07.000000000 +0100
@@ -157,15 +157,6 @@

static int init_kgdboe(void)
{
-#ifdef CONFIG_SMP
- if (num_online_cpus() > CONFIG_NO_KGDB_CPUS) {
- printk
- ("kgdb: too manu cpus. Cannot enable debugger with more than %d cpus\n",
- CONFIG_NO_KGDB_CPUS);
- return -1;
- }
-#endif
-
if (!np.remote_ip || netpoll_setup(&np))
return 1;

@@ -176,4 +167,4 @@
return 0;
}

-module_init(init_kgdboe);
+late_initcall(init_kgdboe); /* This needs to be done after netcard is initialized */
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [W:0.043 / U:0.148 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site