Messages in this thread | | | Date | Fri, 19 Mar 2004 01:32:52 +0100 | From | Jörn Engel <> | Subject | Re: [CFT] inflate.c rework arch testing needed |
| |
On Thu, 18 March 2004 17:10:06 -0600, Matt Mackall wrote: > > I've reworked the mess that is lib/inflate.c, including: > > - proper formatting > - killing a ton of legacy code > - cleaning up IO and CRC handling > - eliminating all the global variables > - using __init for the core kernel > - proper linking rather than the #include "../lib/inflate.c" hack > - lots of minor cleanups along the way > > This drops a ton of support code from all the users of this code as > well: > > arch/arm/boot/compressed/Makefile | 5 > arch/arm/boot/compressed/misc.c | 244 -- > arch/i386/boot/compressed/Makefile | 6 > arch/i386/boot/compressed/misc.c | 224 -- > arch/x86_64/boot/compressed/Makefile | 6 > arch/x86_64/boot/compressed/misc.c | 212 -- > include/linux/inflate.h | 9 > init/do_mounts_rd.c | 129 - > init/initramfs.c | 139 - > lib/Makefile | 4 > lib/inflate.c | 3047 ++++++++++++++++----------------- > 11 files changed, 1688 insertions(+), 2337 deletions(-)
I like the patch in general. This is definitely the wrong time for it, but at least parts of it could go into 2.7 sometime.
Have you thought about updating to a more recent version of zlib? It is most likely not worth it but I'd like to know for sure.
Jörn
-- To recognize individual spam features you have to try to get into the mind of the spammer, and frankly I want to spend as little time inside the minds of spammers as possible. -- Paul Graham - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |