lkml.org 
[lkml]   [2004]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [3C509] Fix sysfs leak.
Dave Jones wrote:
> On Tue, Mar 16, 2004 at 11:56:37AM +0100, Marc Zyngier wrote:
> > >>>>> "davej" == davej <davej@redhat.com> writes:
> >
> > davej> #ifdef CONFIG_EISA
> > davej> - if (eisa_driver_register (&el3_eisa_driver) < 0) {
> > davej> + if (eisa_driver_register (&el3_eisa_driver) <= 0) {
> > davej> eisa_driver_unregister (&el3_eisa_driver);
> > davej> }
> > davej> #endif
> >
> > This is bogus. eisa_driver_register returns 0 when it *succeeds*.
>
> Then the probing routine is bogus, it returns 0 when it fails too.

No, for the hotplug case the API allows registration to succeed, then
probing calls the ->init_one function later.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [W:2.428 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site