Messages in this thread | | | Date | Mon, 15 Mar 2004 05:25:41 +0100 | From | Herbert Poetzl <> | Subject | Re: [PATCH] Bind Mount Extensions 0.04 (linux-2.6.4) |
| |
On Sun, Mar 14, 2004 at 08:14:57PM -0800, Andrew Morton wrote: > Herbert Poetzl <herbert@13thfloor.at> wrote: > > > > ; this patch adds some functionality to the --bind > > ; type of vfs mounts. > > This won't apply any more. We very recently changed a large number of > filesystems to not call update_atime() from within their readdir functions. > That operation was hoisted up to vfs_readdir().
good decision, very recently probably means in the bk repository, is there any link where I could download those changes?
> Also, rather than adding MNT_IS_RDONLY() and having to remember to check > both the inode and the mount all over the kernel it would be better to > change IS_RDONLY() to take two arguments - the inode and the vfsmnt. That > way we won't miss places, and unconverted code simpy won't compile, thus > drawing attention to itself. I don't know if this is feasible, but please > consider it.
I don't have a problem with that, and it sounds good to me so far, so I'll have a look at it, and will update the patch accordingly ...
thanks for the response, Herbert
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |