lkml.org 
[lkml]   [2004]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: possible kernel bug in signal transit.
Alex Lyashkov <shadow@psoft.net> wrote:
>
> Hello All
>
> I analyze kernel vanila 2.6.4 and found one possible bug in
> __kill_pg_info function.
>
> for_each_task_pid(pgrp, PIDTYPE_PGID, p, l, pid) {
> err = group_send_sig_info(sig, info, p);
> if (retval)
> retval = err;
> }
> but I think if (retval) is incorrect check. possible this cycle must be
> for_each_task_pid(pgrp, PIDTYPE_PGID, p, l, pid) {
> err = group_send_sig_info(sig, info, p);
> if (ret) {
> retval = err;
> break;
> }
> }
> because in original variant me assign to retval only first value from
> ret and other be ignored if this value be 0.
>

No, the code's OK, albeit undesirably obscure. It will return -ESRCH if
none of the tasks had a matching pgrp and will return the result of the
final non-zero-returning group_send_sig_info() if one or more of the
group_send_sig_info() calls failed, and will return zero if all of the
group_send_sig_info() calls returned zero.

Thanks for checking though..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [from the cache]
©2003-2011 Jasper Spaans