lkml.org 
[lkml]   [2004]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Manfreds patch to distribute boot allocations across nodes
Anton Blanchard <anton@samba.org> wrote:
>
> Manfred had a patch to distribute kmallocs across nodes during boot.

He's a handy guy.

> ...
>
> Change in free memory due to patch:
>
> Node 7 -54.08 MB
> Node 6 -6.33 MB
> Node 5 -6.09 MB
> Node 4 -6.14 MB
> Node 3 -22.15 MB
> Node 2 -6.05 MB
> Node 1 -6.12 MB
> Node 0 107.35 MB

OK.

> +#ifdef CONFIG_NUMA

Is this a thing which all NUMA machines want to be doing?

> +static __init unsigned long get_boot_pages(unsigned int gfp_mask, unsigned int order)
> +{
> +static int nodenr;
> + int i = nodenr;
> + struct page *page;
> +
> + for (;;) {
> + if (i > nodenr + numnodes)
> + return 0;
> + if (node_present_pages(i%numnodes)) {
> + struct zone **z;
> + /* The node contains memory. Check that there is
> + * memory in the intended zonelist.
> + */
> + z = NODE_DATA(i%numnodes)->node_zonelists[gfp_mask & GFP_ZONEMASK].zones;
> + while (*z) {
> + if ( (*z)->free_pages > (1UL<<order))
> + goto found_node;
> + z++;
> + }
> + }
> + i++;
> + }
> +found_node:
> + nodenr = i+1;
> + page = alloc_pages_node(i%numnodes, gfp_mask, order);
> + if (!page)
> + return 0;
> + return (unsigned long) page_address(page);
> +}
> +#endif

Should this not search for the emptiest node?

> @@ -688,6 +724,10 @@
> {
> struct page * page;
>
> +#ifdef CONFIG_NUMA
> + if (unlikely(!system_running))
> + return get_boot_pages(gfp_mask, order);
> +#endif

Is non-__init code allowed to call __init code? I thought that caused
linkage errors on some setups. Pretty sure about that. I think, maybe.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:00    [W:1.592 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site