![]() | |||||||||||||
Messages in this thread |
>> +#ifdef CONFIG_NUMA >> + #ifdef CONFIG_X86_NUMAQ >> + #include <asm/numaq.h> >> + #else /* summit or generic arch */ >> + #include <asm/srat.h> >> + #endif >> +#else /* !CONFIG_NUMA */ >> + #define get_memcfg_numa get_memcfg_numa_flat >> + #define get_zholes_size(n) (0) >> +#endif /* CONFIG_NUMA */ > > We ran into a bug with #ifdefs like this before. It was fixed in some > of the code that you're trying to remove. What bug? > It's not safe to assume that NUMA && !NUMAQ means SUMMIT. Remember the > linking errors we got when we turned CONFIG_NUMA on with the regular PC > config? The generic arch wasn't a problem because it sets > CONFIG_X86_SUMMIT and compiles in the summit code, but the regular PC > code doesn't. > > Also, I don't think we need the #ifdef CONFIG_NUMA around the whole > block. How about something like this? If you want to go change it, and test the crap out of it for 3 months on a variety of platforms, then go for it. What's here works, and is well tested - I'm sticking with it, unless you can point out a specific case where it's wrong. M. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 13:00 [from the cache] ©2003-2008 | |||||||||||||