Messages in this thread | | | Date | Sat, 7 Feb 2004 01:22:50 +0000 | From | viro@parcelfa ... | Subject | Re: fbdev sysfs support. |
| |
On Fri, Feb 06, 2004 at 05:19:16PM -0800, Greg KH wrote: > On Sat, Feb 07, 2004 at 01:10:48AM +0000, viro@parcelfarce.linux.theplanet.co.uk wrote: > > On Sat, Feb 07, 2004 at 01:01:35AM +0000, James Simmons wrote: > > > +static void release_fb_info(struct class_device *class_dev) > > > +{ > > > + struct fb_info *info = to_fb_info(class_dev); > > > + > > > + /* This doesn't harm */ > > > + fb_dealloc_cmap(&info->cmap); > > > + > > > + kfree(info); > > > +} > > > > So what has happens when we hit existing kfree() on fb_info while sysfs > > node is busy? > > This function will not get called until the sysfs node stops being busy, > so it should all work properly. But only if that fb_info structure was > allocated dynamically, unlike all of the current fb drivers (see my > other comment about this patch.)
This function will not. Already existing kfree() in the drivers, OTOH, will. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |