lkml.org 
[lkml]   [2004]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: fbdev sysfs support.
    On Sat, Feb 07, 2004 at 01:01:35AM +0000, James Simmons wrote:
    > diff -urN -X /home/jsimmons/dontdiff linus-2.6/drivers/video/fbmem.c fbdev-2.6/drivers/video/fbmem.c
    > --- linus-2.6/drivers/video/fbmem.c 2004-01-27 19:48:11.000000000 -0800
    > +++ fbdev-2.6/drivers/video/fbmem.c 2004-02-06 03:45:53.000000000 -0800
    > @@ -1228,6 +1228,9 @@
    > break;
    > fb_info->node = i;
    >
    > + if (fb_add_class_device(fb_info))
    > + return -EINVAL;
    > +

    Woah, what about all of the fb drivers that statically allocate their
    fb_info structure? This will die a horrible death for them when they
    try to unload themselves.

    Are you going to fix up every fb driver to call framebuffer_alloc() to
    fix this problem? That's quite a task...

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 14:00    [W:0.046 / U:0.888 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site