[lkml]   [2004]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [BUG] unsafe reset in ac97_codec.c
    On Iau, 2004-02-05 at 16:31, Liam Girdwood wrote:
    > I agree, but I think we need to be aware of the codec type before we do
    > a register reset. This type of codec is now becoming popular in PDA's.

    Sometimes we can't even find out but yes I agree

    > I can see another problem with the current probe implementation.
    > Currently it sends the register reset command without first checking the
    > codec ready bit. This assumes that the AC97 link is up and completely
    > working before probe is called.

    It is (in theory) the job of the calling driver to ensure AC97 is up
    before doing the reset part.

    > I'll implement this if it's acceptable as I can test it on both types of
    > codec.

    Sounds right to me

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 14:00    [W:0.028 / U:8.280 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site