Messages in this thread | | | Date | Tue, 3 Feb 2004 15:57:52 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] meye: correct printk of dma_addr_t |
| |
"Randy.Dunlap" <rddunlap@osdl.org> wrote: > > diff -Naurp ./drivers/media/video/meye.c~meye_dma ./drivers/media/video/meye.c > --- ./drivers/media/video/meye.c~meye_dma 2004-01-08 22:59:44.000000000 -0800 > +++ ./drivers/media/video/meye.c 2004-02-03 14:43:42.000000000 -0800 > @@ -162,7 +162,7 @@ static void rvfree(void * mem, unsigned > > /* return a page table pointing to N pages of locked memory */ > static int ptable_alloc(void) { > - u32 *pt; > + dma_addr_t *pt; > int i; > > memset(meye.mchip_ptable, 0, sizeof(meye.mchip_ptable)); > @@ -176,7 +176,7 @@ static int ptable_alloc(void) { > return -1; > } > > - pt = (u32 *)meye.mchip_ptable[MCHIP_NB_PAGES]; > + pt = (dma_addr_t *)meye.mchip_ptable[MCHIP_NB_PAGES]; > for (i = 0; i < MCHIP_NB_PAGES; i++) { > meye.mchip_ptable[i] = dma_alloc_coherent(&meye.mchip_dev->dev, > PAGE_SIZE,
mchip_ptable[] just contains pointers to kernel memory. It doesn't seem appropriate to be casting these to dma_addr_t's
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |