Messages in this thread | | | Subject | 2.6 probe.c "pcibus_class" Device Class, release function | From | John Rose <> | Date | Tue, 03 Feb 2004 16:33:39 -0600 |
| |
The function release_pcibus_dev() in probe.c defines the release procedure for device class pcibus_class. I want to suggest that this function be scrapped :)
This release function is called in the code path of class_device_unregister(). The pcibus_class devices aren't currently unregistered anywhere, from what I can tell, so this release function is currently unused. The runtime removal of PCI buses from logical partitions on PPC64 requires the unregistration of these class devices. The natural place to do this IMHO is in pci_remove_bus_device() in remove.c.
The problem is that this calls pci_destroy_dev(), which calls put() on the same "bridge" device that the release function does. This should only be done once in the course of removing a pci_bus, and I doubt that we want to change pci_destroy_dev(). The kfree() of the pci_bus struct is also done in both pci_remove_bus_device() and release_pcibus_dev().
So the only two operations in the release function are redundantly performed in the place where it makes sense to unregister. For these reasons, I think we should scrap the release function altogether and set that pointer in the struct class to NULL.
Thoughts? John
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |