![]() | |||||||||||||
Messages in this thread |
On Tue, 3 Feb 2004, Matt Mackall wrote: > On Sun, Feb 01, 2004 at 10:43:44PM -0800, Andrew Morton wrote: > > +extern asmlinkage long sys_unlink(const char __user *pathname); > > +extern asmlinkage long sys_chmod(const char __user *filename, mode_t mode); > > +extern asmlinkage long sys_fchmod(unsigned int fd, mode_t mode); > > > > Maybe lose the `extern' too. It's just a waste of space. I normally put > > it in for consistency if the surrounding code is done that way, but for a > > new header file, why bother? > > I'd really like to see the extern go, if only to discourage that > particular bit of cargo cult programming. There are actually people > who think it serves a purpose.. > > -- > Matt Mackall : http://www.selenic.com : Linux development and consulting THey got 'em advertised on eBay for $10.99 ;^ Cheers, Dick Johnson Penguin : Linux version 2.4.24 on an i686 machine (797.90 BogoMips). Note 96.31% of all statistics are fiction. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 13:00 [from the cache] ©2003-2008 | |||||||||||||